Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated exit code for when we find dead code #319

Merged
merged 5 commits into from
Aug 20, 2023
Merged

Add dedicated exit code for when we find dead code #319

merged 5 commits into from
Aug 20, 2023

Conversation

whosayn
Copy link
Contributor

@whosayn whosayn commented Aug 19, 2023 •
edited
Loading

Description

This introduces a new class vulture.utils.ExitCode, which will encode the different exit codes vulture can return.

Related Issue

#308

Checklist:

  • I have updated the documentation in the README.md file or my changes don't require an update.
  • I have added an entry in CHANGELOG.md.
  • I have added or adapted tests to cover my changes.
  • I have run tox -e fix-style to format my code and checked the result with tox -e style.

@whosayn
Adding dedicated exit code for "Dead Code found"
6780ffd 
This addresses issue jendrikseipp#308 by introducing a new class
vulture.utils.ExitCode, which will encode the different exit codes
vulture can return.
@whosayn
Adding dedicated exit code for "Dead Code found"
607bf89 
This addresses issue jendrikseipp#308 by introducing a new class
vulture.utils.ExitCode, which will encode the different exit codes
vulture can return.
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023 •
edited by codecov bot
Loading

Codecov Report

Merging #319 (e9bb78e) into main (0ba4ee7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   98.94%   98.96%   +0.01%     
==========================================
  Files          21       21              
  Lines         665      676      +11     
==========================================
+ Hits          658      669      +11     
  Misses          7        7
Files Changed Coverage Δ
vulture/config.py 98.46% <100.00%> (+0.10%) ⬆️
vulture/core.py 98.53% <100.00%> (+<0.01%) ⬆️
vulture/utils.py 98.71% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@whosayn whosayn changed the title Issue308 Add dedicated exit code for when we find dead code Aug 19, 2023
jendrikseipp
jendrikseipp requested changes Aug 19, 2023
View reviewed changes
Copy link
Owner

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I like your enum refactoring! Once you've taken care of my small nitpicks, this can be merged.

tests/test_script.py Outdated Show resolved Hide resolved
vulture/core.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jendrikseipp jendrikseipp merged commit c264fb8 into jendrikseipp:main Aug 20, 2023
17 checks passed
@jendrikseipp
Copy link
Owner

Thanks!

@jendrikseipp jendrikseipp mentioned this pull request Aug 20, 2023
Closed
@whosayn whosayn deleted the issue308 branch August 20, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jendrikseipp jendrikseipp jendrikseipp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whosayn @codecov-commenter @jendrikseipp