Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator name regression #284

Merged
merged 8 commits into from
Aug 20, 2023
Merged

Decorator name regression #284

merged 8 commits into from
Aug 20, 2023

Conversation

jendrikseipp
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #284 (9b640e6) into main (c264fb8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9b640e6 differs from pull request most recent head 8e9c584. Consider uploading reports for the commit 8e9c584 to get more accurate results

@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files          21       21           
  Lines         676      679    +3     
=======================================
+ Hits          669      672    +3     
  Misses          7        7           
Files Changed Coverage Δ
vulture/utils.py 98.76% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

vulture/noqa.py Outdated
@@ -3,7 +3,7 @@

NOQA_REGEXP = re.compile(
# Use the same regex as flake8 does.
# https://gitlab.com/pycqa/flake8/-/tree/master/src/flake8/defaults.py
# https://gitlab.com/pycqa/flake8/-/tree/main/src/flake8/defaults.py
Copy link
Contributor

@RJ722 RJ722 Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 moved to GitHub last year. Let's use the new URL instead?

Suggested change
# https://gitlab.com/pycqa/flake8/-/tree/main/src/flake8/defaults.py
# https://github.com/PyCQA/flake8/blob/main/src/flake8/defaults.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like these changes are only appearing here because GitHub wasn't able to rebase this branch (probably because of the master -> main rename). Changes already went in fb126c7. I'll send a PR separately.

@jendrikseipp
Copy link
Owner Author

This PR is probably redundant because #285 tackles the same problem.

@jendrikseipp jendrikseipp merged commit fc23f33 into main Aug 20, 2023
15 checks passed
@jendrikseipp jendrikseipp deleted the decorator-name-regression branch August 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants