Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo.get_walker confused about type of SHA #1075

Closed
sattlerc opened this issue Oct 22, 2022 · 2 comments
Closed

Repo.get_walker confused about type of SHA #1075

sattlerc opened this issue Oct 22, 2022 · 2 comments

Comments

@sattlerc
Copy link
Contributor

This makes it seem str is expected, but in fact

repo.get_walker(include = '0' * 40)

results in:

AttributeError: 'str' object has no attribute 'decode'
@sattlerc
Copy link
Contributor Author

Note that Walker.__init__ already has this:

        if isinstance(include, bytes):
            # TODO(jelmer): Really, this should require a single type.
            # Print deprecation warning here?
            include = [include]

So presumably this can just be deleted.

@jelmer
Copy link
Owner

jelmer commented Oct 22, 2022

object ids are always bytestrings in Dulwich

The line you're referencing is a remnant from when Dulwich supported Python 2; I've create a PR to remove it. Thanks!

@jelmer jelmer closed this as completed in 260a6d9 Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants