Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document.fonts.keys() is not iterable on Firefox #2432

Closed
EffakT opened this issue Aug 18, 2024 · 1 comment
Closed

document.fonts.keys() is not iterable on Firefox #2432

EffakT opened this issue Aug 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@EffakT
Copy link
Contributor

EffakT commented Aug 18, 2024

Description of the bug

The recent change to ensure all resources are loaded before mount causes a bug in Firefox, as document.fonts does not return an Iterator in Firefox, rather a FontFaceSetIterator.

See below bugreport @ Mozilla
https://bugzilla.mozilla.org/show_bug.cgi?id=1311198

There is a potential fix by Sidney Liebrand
https://sidneyliebrand.io/blog/fixing-font-face-set-entries-not-iterable-in-firefox

Steps to reproduce

Load current release in firefox

Expected behavior

Page should load

Logs

No response

Screenshots

No response

Platform

macOS

Browser

Firefox

Jellyfin server version

10.9.2

Additional context

No response

@EffakT EffakT added the bug Something isn't working label Aug 18, 2024
@ferferga
Copy link
Member

ferferga commented Aug 21, 2024

What a bad joke... 😓

There was a reason why that branch wasn't merged yet, not only because it's unfinished, but for testing it properly. Thought this change would be harmless and since I'm on vacation just with my laptop (no Firefox installed) just omitted checking it completely.

I'll try to open a PR later today. I'm really grateful for all the investigation work you already did, definitely makes things much easier! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants