Subsonic plaintext auth does not properly escape special characters

[pogmommy]

Expected Behavior

Logging into feishing using subsonic plaintext auth when special characters are present in the username/password field should log in and present the user with the default screen.
Special characters should be appropriately substituted in network requests, such as # with %23, and + with %2B.

Current Behavior

Attempting to log into feishin using subsonic plaintext authentication with special characters in the username/password field fails with large number of notices reading:

An error occurred
Wrong username or password.

In the network requests, # is replaced with %2523 and + is replaced with %252B, which seems to indicate that after the special characters are encoded, the resulting percent characters are then encoded again.

This issue does not seem to be present in ping.view and getPlaylists.view network requests, and seemingly some others. It is present in getAlbumList2.view, which prevents the main screen from loading.

Steps to Reproduce

1. Download and launch feishin 0.12.1 x86_64 appimage
2. Open 'manage server' modal and press 'add server'
3. Select 'Subsonic' server type
4. Enter server name and url
5. enter username and password containing special characters
6. Enable 'legacy authentication'
7. attempt to log in

Possible Solution

Removing the explicit encoding added here in related PR #850 enables proper encoding of relevant characters in getAlbumList2.view , but then the characters are not encoded properly elsewhere and you get seemingly the same issue from version 0.12.0 and prior.

Context

No response

Application version

0.12.1

Operating System and version

Debian Linux Sid

Server and Version

airsonic-advanced 11.0.0-SNAPSHOT.20240424015024

Node Version (if developing locally)

n/a