New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded lyrics show gibberish #468

Closed

isle9 opened this issue Jan 23, 2024 · 2 comments · Fixed by #484

Assignees

Labels

bug

isle9 commented Jan 23, 2024

Current Behavior

Your Environment

Application version (e.g. v0.1.0) : 0.5.3
Operating System and version (e.g. Windows 10) : Ubuntu 23.10
Server and version (e.g. Navidrome v0.48.0) : Navidrome 0.51.0

isle9 added the bug label

Insprill commented Jan 25, 2024 •

edited

Loading

I can confirm this with Navidrome v0.51.0 playing a FLAC file with embedded lyrics.

In addition, it doesn't look up lyrics online anymore, even when the track has none embedded.

Contributor

TacoCake commented Jan 30, 2024 •

edited

Loading

Navidrome added 'Structured lyrics' in their newest release, which changed the behaviour for lyrics.

https://github.com/navidrome/navidrome/releases/tag/v0.51.0

The function needs modifications to handle the new response structure. Until then, you can roll back navidrome or wait for an update to feishin

kgarner7 linked a pull request

that will close this issue

[bugfix/enhancement]: Support Navidrome structured lyrics #484

Merged

kgarner7 self-assigned this

jeffvli closed this as completed in #484

This was referenced Feb 15, 2024

Lyrics loading error #507

Closed

Lyrics are shown as json #516

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment