Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ":albumId" param after selecting "Random" sorting in Tracks tab #378

Closed
manuel-rw opened this issue Nov 12, 2023 · 12 comments · Fixed by #553
Closed

Missing ":albumId" param after selecting "Random" sorting in Tracks tab #378

manuel-rw opened this issue Nov 12, 2023 · 12 comments · Fixed by #553
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@manuel-rw
Copy link

manuel-rw commented Nov 12, 2023

Expected Behavior

The Tracks tab shows the songs of Jellyfin.

Current Behavior

The page does not load and shows a warning after I switched to "Random" sorting.
Now I can't reset the sorting.

image

Restarting the application does not fix it.

Possible Solution (Not obligatory)

  • Make the album id optional
  • Application version (e.g. v0.1.0) : 0.5.1
  • Operating System and version (e.g. Windows 10) : Windows 11, amd64
  • Server and version (e.g. Navidrome v0.48.0) : Jellyfin 10.8.12, Docker, x64)
  • Node version (if developing locally) : N/A
@manuel-rw manuel-rw added the bug Something isn't working label Nov 12, 2023
@jeffvli
Copy link
Owner

jeffvli commented Nov 12, 2023

For a temporary fix, open up the dev tools with ctrl+shift+i and remove the store_song key from local storage to reset the filter.

image

@jeffvli
Copy link
Owner

jeffvli commented Nov 12, 2023

Actually, I'm unable to reproduce this issue on my side -- also using Jellyfin 10.8.12.

@jeffvli jeffvli self-assigned this Nov 12, 2023
@iiPythonx
Copy link
Contributor

Jellyfin 10.9.0, not seeing this issue.

@manuel-rw
Copy link
Author

I'll close this issue as I haven't been able to reproduce this myself.

@manuel-rw manuel-rw closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
@m00dymann
Copy link

m00dymann commented Jan 11, 2024

I have run into the same problem on web version.

Edit: It happens when I swap from "Display type: Table" to Display type: Poster" whilst in the Tracks tab.
Songs were sorted by recently added in descending order.
Am using Brave browser.

@manuel-rw manuel-rw reopened this Jan 11, 2024
@kgarner7 kgarner7 added the help wanted Extra attention is needed label Jan 28, 2024
@kgarner7
Copy link
Collaborator

This bug appears to happen when you have a song without an album id; in this case, the LIBRARY_ALBUMS_DETAIL path breaks. I am able to reproduce this in Jellyfin 10.8.13 and unstable (for some reason Jellyfin just refuses to acknowledge my albums...).
This issue happens for Jellyfin when in Card/Poster display for songs. Unfortunately, I'm not sure how to address this...

@timaeos
Copy link

timaeos commented Mar 20, 2024

For those encountering this issue, take a look at #531 .

It seems like this is likely a consequence of having files in the top-level of the Music directory structure. If you have files in the top-level, I'd recommend placing them into a directory to match the structure as noted in the Jellyfin documentation. For singles that don't have associated albums, throwing them into a Singles folder is sufficient.

After updating the directory structure, make sure that you clear Feishin's cache

@kgarner7
Copy link
Collaborator

Adding on here, I will still look into adding a dummy album page when the album ID is nonexistent (Feishin shouldn't just panic even if Jellyfin behavior is strange).

@nothing2obvi
Copy link

I just opened Feishin after using it a few days ago just fine and now I get this same error, only on the Home page. I am running the x64 dmg on an Intel Mac.

@timaeos
Copy link

timaeos commented Mar 29, 2024

I just opened Feishin after using it a few days ago just fine and now I get this same error, only on the Home page. I am running the x64 dmg on an Intel Mac.

@kgarner7 is working on #553 which should hopefully resolve this but in the meantime, check if you have any songs in the top level of your directory structure and if you do, try moving them into a directory and clearing Feishin's cache as noted above

@OriCat101
Copy link

Idk if this helps, but I get the same error even tho I have no "loose" songs kicking around in my library

@YourSandwich
Copy link

Same issue here, when scrolling through Tracks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants