Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Essential] Subsonic API Support #306

Closed
kobayashi90 opened this issue Oct 14, 2023 · 13 comments · Fixed by #758
Closed

[Essential] Subsonic API Support #306

kobayashi90 opened this issue Oct 14, 2023 · 13 comments · Fixed by #758
Labels
enhancement New feature or request

Comments

@kobayashi90
Copy link
Contributor

kobayashi90 commented Oct 14, 2023

Why Feishin does need the Subsonic API Now?
As previously mentioned over here there is an essential need to enable the Subsonic API. Navidrome relies upon it heavly all the time, there are basically no clients that dont rely on navidrome's own api due to compability reasons i assume.

Why there is no reason that we need to wait for Subsonic's API changes?
After researching the Link that got mentioned on the Githubs Readme turnts out there is no eta or any development on new subsonic api changes so there is basically no need to wait for future subsonic api changes.
Even if someone rebuilds it, it takes up months if not years due to how old subsonic is in some regards.
So i hope this gets fixed as fast as possible.

@kobayashi90 kobayashi90 added the enhancement New feature or request label Oct 14, 2023
@Sakooooo
Copy link

image
tried using gonic with feishin it errors out with 'please prodive a 'u' parameter when clicking tracks login doesnt seem to work either

@ProfMoo
Copy link

ProfMoo commented Oct 18, 2023

After researching the Link that got mentioned on the Githubs Readme turnts out there is no eta or any development on new subsonic api changes so there is basically no need to wait for future subsonic api changes.

Just throwing in my 2 cents: It's worth exploring for Feishin to look into the OpenSubsonic API. I believe the OpenSubsonic API is the end result of the thread that was linked in the README

@kobayashi90
Copy link
Contributor Author

kobayashi90 commented Oct 19, 2023

Just throwing in my 2 cents: It's worth exploring for Feishin to look into the OpenSubsonic API. I believe the OpenSubsonic API is the end result of the thread that was linked in the README

Edit: I apologize if this sounds rude, ive had an tantrum about it,.. take your time.
Edit 2: Got notified that they work on it soon, so lets wait until its done.

@Gt1ult
Copy link

Gt1ult commented Nov 4, 2023

Is there any chance to have gonic/opensubsonic as client too? It will be great. At the moment which one is the best client? Jellyfin or Navidrone?

@luopa
Copy link

luopa commented Jan 11, 2024

FYI, its on its way --> #419

@kobayashi90
Copy link
Contributor Author

FYI, its on its way --> #419

It failed tho, not sure how optimistic we should be.. @jeffvli might know..

@iiPythonx
Copy link
Contributor

iiPythonx commented Jan 31, 2024

It failed tho, not sure how optimistic we should be.. jeffvli might know..

Running off of #419, your server "squidify" (from #289) seems to load perfectly fine:

image

Additionally, if by "failed" you meant the "Some checks were not successful" notice, then it's worth noting that's just because of some basic missing configuration when building for MacOS:

image

It should just be a matter of waiting for it to be finalized and merged.

@kobayashi90
Copy link
Contributor Author

It should just be a matter of waiting for it to be finalized and merged.

Indeed great news, i hope it happens soon because till now many people used SoniXD including myself..
I did also use Feishin over an Tailscale connection but its clearly not an option for other listeners.

@kgarner7 kgarner7 mentioned this issue Aug 25, 2024
1 task
@garfieldairlines
Copy link

garfieldairlines commented Sep 14, 2024

Can we get a little estimate when it will be implemented ? I'm still stuck with Sonixd because of the lack of support of Subsonic…

Edit : or release #419 : yes you will say "it's old and you will lack features", but am I really lacking something when Sonixd isn't maintained at all ?

@iiPythonx
Copy link
Contributor

iiPythonx commented Sep 14, 2024

Can we get a little estimate when it will be implemented ?

jeffvli is planning/working on yet another rewrite which according to him will have support for subsonic.
It's not public yet and I don't have any more information about it then that.

Also, if you just want a build of #419, I have a build available here (Linux/Windows only).

@garfieldairlines
Copy link

Also, if you just want a build of #419, I have a build available here.

Oooooooooooooh thank you so much

@kgarner7
Copy link
Collaborator

The likelihood of it hitting Feishin regular as-is is basically none. Unless someone (who is not me) spends the time to refine the linked PR and resolve all merge conflicts, it will likely not happen.

@kgarner7 kgarner7 linked a pull request Sep 14, 2024 that will close this issue
@kgarner7 kgarner7 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
@kgarner7
Copy link
Collaborator

😮‍💨 in light of Navidrome filtering making things worse, I'm taking a stab at this.
Note that it will be a different branch (I'm not dealing with all those merge conflicts). My first goal will be to port over the changes that will support subsonic (without actually supporting subsonic) to make sure the quality of Navidrome/Jellyfin native isn't impacted. If that's the case, then adding Subsonic back is easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants