From a8f5cb7cfa2fec614057d74c41ea53cd02228e23 Mon Sep 17 00:00:00 2001 From: irfan sharif Date: Fri, 10 Mar 2023 17:24:21 -0500 Subject: [PATCH] lint: skip TestLowercaseFunctionNames under --short It takes ~350s on my M1, and is the lone straggler. $ dev lint --short ... --- PASS: TestLint/TestEnvutil (1.51s) --- PASS: TestLint/TestCopyrightHeaders (0.62s) --- PASS: TestLint/TestCrlfmt (8.05s) --- PASS: TestLint/TestGofmtSimplify (9.66s) --- PASS: TestLint/TestMissingLeakTest (5.48s) --- PASS: TestLint/TestLowercaseFunctionNames (357.81s) PASS Release note: None --- pkg/testutils/lint/lint_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/testutils/lint/lint_test.go b/pkg/testutils/lint/lint_test.go index 5148424d81aa..051627d24dd8 100644 --- a/pkg/testutils/lint/lint_test.go +++ b/pkg/testutils/lint/lint_test.go @@ -127,6 +127,7 @@ func TestLint(t *testing.T) { pkgVar, pkgSpecified := os.LookupEnv("PKG") t.Run("TestLowercaseFunctionNames", func(t *testing.T) { + skip.UnderShort(t) t.Parallel() reSkipCasedFunction, err := regexp.Compile(`^(Binary file.*|[^:]+:\d+:(` + `query error .*` + // OK when in logic tests