Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: Pydantic V2 #12

Merged
merged 7 commits into from
Sep 13, 2023
Merged

chore(deps)!: Pydantic V2 #12

merged 7 commits into from
Sep 13, 2023

Conversation

jezumbro
Copy link
Contributor

Upgrade the ObjectIdField to match the internals of Pydantic V2.

Updated all tests and internals based on errors raised by tests.

@jezumbro jezumbro marked this pull request as draft July 10, 2023 14:12
@jezumbro jezumbro marked this pull request as ready for review July 11, 2023 17:30
@jezumbro jezumbro closed this Jul 11, 2023
@jezumbro jezumbro reopened this Jul 11, 2023
@Norbiox
Copy link

Norbiox commented Aug 29, 2023

Could you please downgrade isort to 5.11.5 so it could keep python3.7 compatibility and the pull request could move forward?

@jezumbro
Copy link
Contributor Author

Could you please downgrade isort to 5.11.5 so it could keep python3.7 compatibility and the pull request could move forward?
@Norbiox
Interesting that it is still forcing 5.12.0. Any idea why this would be the case. The requirements_test.txt have the 5.11.5 dependency after the latest commit

@jefersondaniel jefersondaniel changed the title Pydantic v2 chore(deps)!: Pydantic V2 Sep 13, 2023
@jefersondaniel jefersondaniel merged commit 561c122 into jefersondaniel:main Sep 13, 2023
@jefersondaniel
Copy link
Owner

Thanks!

I also merged the PR that drops support to Python 3.7 since it reached EOL. This will be included in the version 2 of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants