-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add SG Location for Amazon and Newegg #1600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixxed bugs found in Mediamarkt / Saturn Webstore, after Change to their shop after 29.12.2020
# Conflicts: # src/store/model/galaxus.ts
…a1564e packing it into an actual feature instead of changing existing files
… when old ones are resolved, mitgating my last changes ). Last try for this pull request, since the feature itself is working without issues.
jef
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thank you very much
jef
changed the title
feat(store): Add SG Location for Amazon and Newegg
feat(store): add SG Location for Amazon and Newegg
Jan 7, 2021
erwinc1
pushed a commit
to erwinc1/streetmerchant
that referenced
this pull request
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Singapure Location based upon lawliet89/streetmerchant update ca1564e packing it into an actual feature instead of changing existing files.
Testing
ran script for 5 runs in both stores. Works as intended.