fix(amazon-de-warehouse): update wrong maxPrice selector #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you again for your commitment, think it's great that the @jef here is so actively supported by you. |
jef
approved these changes
Dec 26, 2020
jef
changed the title
jef
changed the title
jef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1500
maxPrice selector was not matching properly for warehouse listings.
Testing
Create a link in amazon-de-warehouse.ts targeting a product that has warehouse listings
Set MAX_PRICE for the link's defined product to something less than the lowest warehouse listing
Run
New dependencies
None