-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add redis #1390
feat: add redis #1390
Conversation
Great! This will be useful for things coming up in 4.0.0 as well. Thank you! |
@jef Of course! I am fixing these CI errors and I am going to add more options to pass into the redis client. |
into main Signed-off-by: Bailey Miller <[email protected]>
@jef |
Haha, I'm sorry. I can be hell sometimes. Let's take a look when it's done building. Your best bet is usually running Looks like it's good now! Thanks for taking the time to fix that 😅 Sorry about it. |
I think I got it this time, I am using the prettier extension for VS Code but some of the auto formats are against the CI rules but I think I managed to figure it out through trial and error. |
@jef I would really like to figure out how to have this run on every pass. Meaning this currently only updates Redis if the notification gets triggered. I would like Redis to be updated every time a page is loaded and it's either in/out of stock. I am currently letting this run for a bit so I can see how it looks once something comes into stock. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I love it. We should add this to the docker-compose sometime. Could be cool.
Thanks!
Windows User Need redis Server start |
Made a fix in the latest commits to not have it required. Thank you! |
Description
Adds Redis as a way to keep track of stock. Redis connection string can be passed in to meet many different configurations.
Testing
New dependencies
redis
@types/redis