fix(newegg): dedupe nitro+ models #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If your test is successful - similar approach might fix 1294 as well. I see for Amazon the same brand, model, series ....longer term fix might be to strip product number and include that in the max price check so that it doesn't just hit the first brand/model/series it finds in the dictionary/array |
jef
reviewed
Dec 11, 2020
changed nitro+ SE to nitro+ se
|
updated as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1230
There were two Nitro+ models for newegg with same brand/model/series
Added a a new model type and updated the second Nitro+ in newegg
Testing
nada