feat(notification): add discord groups #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/config.ts # src/notification/discord.ts
# Conflicts: # README.md
jef
requested changes
Dec 7, 2020
There was a problem hiding this comment.
This is great! I know I've been asked for this a few times now!
If you could just make the documentation change, that would be great.
I think this is also another reason why I have been working on https://github.com/jef/streetmerchant/tree/prerelease/4.0.0.
Config drift is hellish 🙃
jef
requested changes
Dec 8, 2020
styler2go
commented
Dec 8, 2020
styler2go
commented
Dec 9, 2020
code review
jef
approved these changes
Dec 9, 2020
jef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added the option to select specific discord groups for each series. I made it because it was requested in my discord. If you don't need it feel free to decline/close this request