Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fix for eprice.ts (Eprice.it italian store) #1067

Closed
Maecenass opened this issue Dec 1, 2020 · 0 comments
Closed

Code fix for eprice.ts (Eprice.it italian store) #1067

Maecenass opened this issue Dec 1, 2020 · 0 comments

Comments

@Maecenass
Copy link

Maecenass commented Dec 1, 2020

Description

Hi guys, i don't know how to request a code change because i'm a noob so i'll paste the fixed code for eprice.ts

Previous code:

import {Store} from './store';

export const Eprice: Store = {
	labels: {
		inStock: {
			container: '.form_aggiungi_articolo',
			text: ['AGGIUNGI AL CARRELLO']
		},
		maxPrice: {
			container: '#PrezzoClasic span[class*="big"]',
			euroFormat: true
		}
	},
	links: [
		{
			brand: 'msi',
			model: 'ventus 3x oc',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-MSI/d-14039974'
		},
		{
			brand: 'asus',
			model: 'dual',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-ASUS/d-14042082'
		},
		{
			brand: 'asus',
			model: 'strix',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-ASUS/d-14039878'
		},
		{
			brand: 'asus',
			model: 'tuf',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-ASUS/d-14039876'
		},
		{
			brand: 'msi',
			model: 'gaming',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-MSI/d-14039972'
		},
		{
			brand: 'msi',
			model: 'ventus 3x oc',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-MSI/d-14039974'
		},
		{
			brand: 'msi',
			model: 'ventus 2x oc',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-MSI/d-14039973'
		},
		{
			brand: 'zotac',
			model: 'gaming',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-ZOTAC/d-13979806'
		},
		{
			brand: 'sony',
			model: 'ps5 console',
			series: 'sonyps5c',
			url: 'https://www.eprice.it/playstation-5-SONY/d-13981612'
		},
		{
			brand: 'sony',
			model: 'ps5 digital',
			series: 'sonyps5de',
			url: 'https://www.eprice.it/playstation-5-SONY/d-13981613'
		}
	],
	name: 'eprice'
};

New code:

import {Store} from './store';

export const Eprice: Store = {
	labels: {
		inStock: {
			container: '.topSideDx',
			text: ['disponibile', 'pochi pezzi']
		},
		maxPrice: {
			container: '#PrezzoClasic span[class*="big"]',
			euroFormat: true
		}
	},
	links: [
		{
			brand: 'msi',
			model: 'ventus 3x oc',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-MSI/d-14039974'
		},
		{
			brand: 'asus',
			model: 'dual',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-ASUS/d-14042082'
		},
		{
			brand: 'asus',
			model: 'strix',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-ASUS/d-14039878'
		},
		{
			brand: 'asus',
			model: 'tuf',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-ASUS/d-14039876'
		},
		{
			brand: 'msi',
			model: 'gaming',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-MSI/d-14039972'
		},
		{
			brand: 'msi',
			model: 'ventus 3x oc',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-MSI/d-14039974'
		},
		{
			brand: 'msi',
			model: 'ventus 2x oc',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-MSI/d-14039973'
		},
		{
			brand: 'zotac',
			model: 'gaming',
			series: '3070',
			url: 'https://www.eprice.it/schede-video-ZOTAC/d-13979806'
		},
		{
			brand: 'sony',
			model: 'ps5 console',
			series: 'sonyps5c',
			url: 'https://www.eprice.it/playstation-5-SONY/d-13981612'
		},
		{
			brand: 'sony',
			model: 'ps5 digital',
			series: 'sonyps5de',
			url: 'https://www.eprice.it/playstation-5-SONY/d-13981613'
		}
	],
	name: 'eprice'
};

EXPLANATION
This prevents the bot from giving false positives.

@jef jef removed their assignment Dec 8, 2020
@jef jef closed this as completed in 5e1dfc3 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants