Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaking global variables #8

Open
dankirkpatrick opened this issue Jan 24, 2017 · 1 comment
Open

Leaking global variables #8

dankirkpatrick opened this issue Jan 24, 2017 · 1 comment

Comments

@dankirkpatrick
Copy link

You're leaking global variables. You need to declare them as "var" so they don't get declared with global scope. The following variables are leaking (for the functions, you are exporting them then declaring them as global variables):

applicationPrefix
addCompletions
addFromFile
getWordCompletions
getPhraseCompletions
search
phraseToStore
rangelen

@konsumer
Copy link

In node, the default isn't global (like in browser: window) it's module if not scoped, so they aren't global, just local to the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants