Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

Don't Strip BOMs #50

Merged
merged 4 commits into from
Feb 27, 2017
Merged

Don't Strip BOMs #50

merged 4 commits into from
Feb 27, 2017

Conversation

gucong3000
Copy link
Collaborator

@gucong3000 gucong3000 commented Feb 27, 2017 •
edited by jednano
Loading

Fixes #40

Note: Since this tool is itself a Gulp plugin, all BOM signatures will be stripped off internally by means of strip-bom. There's not much that can be done about this, but if you specify a supported charset in your .editorconfig file the BOMs will be inserted or re-inserted before they are written.

This issue can fix by this PR.

https://github.com/gulpjs/vinyl-fs#optionsstripbom

@jednano
Copy link
Owner

jednano commented Feb 27, 2017

Awesome, thanks!

@jednano jednano merged commit 39f5161 into jednano:master Feb 27, 2017
@gucong3000 gucong3000 deleted the not_strip_bom branch February 28, 2017 11:21
@gucong3000
Copy link
Collaborator Author

#40 fixed

@jednano
Copy link
Owner

jednano commented Mar 3, 2017

I didn't release a new version w/ these changes yet, however. Waiting for your other PR.

@jednano jednano changed the title Not strip bom Don't Strip BOMs Mar 22, 2017
@jednano jednano mentioned this pull request Mar 22, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to recognize utf-8-bom
2 participants
@gucong3000 @jednano