Handle Download URL for insider

[GitMensch]

You will need to set the setting "remote.SSH.serverDownloadUrlTemplate": "https://github.com/VSCodium/vscodium-insiders/releases/download/${version}.${release}-insider/vscodium-reh-${os}-${arch}-${version}.${release}-insider.tar.gz",

Originally posted by @daiyam in #24 (comment)

use correct insider URL when running on insider

not sure about hardcoding other download urls, we can add them to the readme though and it's not that bad as you just need to do it once

Originally posted by @jeanp413 in #24 (comment)

I'd vote for hardcoding the two most common paths and declare victory (everything else will possibly lead to a bunch of "the download failed" issues), but in any case it should be handled somehow which can be tracked in this issue.

[GitMensch]

Rechecking: it seems the issue is two-fold (and in general we don't need a "second" URL):

• main issue: generateServerInstallScript: should have quality set to -insider when running an insider version
• ServerInstallOptions -> serverDownloadUrlTemplate may need an update to https://github.com/VSCodium/vscodium${quality}/releases/download/${version}.${release}${quality}/vscodium-reh-${os}-${arch}-${version}.${release}${quality}.tar.gz

@daiyam to enable this to work we'd either have to rename https://github.com/VSCodium/vscodium-insiders to https://github.com/VSCodium/vscodium-insider (dropping the "s"), which I suggest; or change the generated name to use insiders in all places instead of insider. What do you think?

[GitMensch]

ping @daiyam

Also: Could you adjust the default runtime arguments to include

{
    "enable-proposed-api": [
        ...,
        "jeanp413.open-remote-ssh",
    ]
}

?

[daiyam]

In product.json, I'm adding (same apis as ms-vscode-remote.remote-ssh):

"jeanp413.open-remote-ssh": [
      "resolvers",
      "tunnels",
      "terminalDataWriteEvent",
      "contribViewsRemote"
    ]

It will be in the next Insiders build.

[daiyam]

@daiyam to enable this to work we'd either have to rename https://github.com/VSCodium/vscodium-insiders to https://github.com/VSCodium/vscodium-insider (dropping the "s"), which I suggest; or change the generated name to use insiders in all places instead of insider. What do you think?

We can't drop the s since:

• Insiders is the product name
• some binaries have insiders due to MS code

Maybe add a new variable product-quality which would contain the additional s?

[daiyam]

The extension is working out of the box with the latest Insiders.

[GitMensch]

Even without any download URL setting? Can you please apply the same patch for the stable build (the next release is expected next week, so now is a good time) to adjust that.

[daiyam]

Sorry, with "remote.SSH.serverDownloadUrlTemplate": "https://github.com/VSCodium/vscodium-insiders/releases/download/${version}.${release}-insider/vscodium-reh-${os}-${arch}-${version}.${release}-insider.tar.gz",

[GitMensch]

@daiyam if I understand you correctly you've suggested a code change to not need a manual URL setup, correct?
Can you please create a PR (even if it isn't fully working yet) to showcase the suggestion?

[daiyam]

No, sorry. I meant the change for "enable-proposed-api": [ "jeanp413.open-remote-ssh"] isn't needed anymore...

[GitMensch]

Maybe add a new variable product-quality which would contain the additional s?

Where would that be done?

[jeanp413]

Released a new version 0.0.26

[GitMensch]

Checked: works fine now with VSCodium-Insiders without any manual setup, same for VSCodium (no startup configuration, no termplate setting, ...).

Maybe the docs should be adjusted to explicit no speak about VSCodium any more?