Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module is not detecting that Windows Terminal is installed when run from Windows Terminal Preview #6

Closed
rkeithhill opened this issue Aug 1, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@rkeithhill
Copy link

rkeithhill commented Aug 1, 2020

I have both Windows Terminal and Windows Termina Preview installed. When I have only preview running, I get a warning about it not being installed:

image

However, I don't get this warning from Windows Terminal nor do I get it in preview IFF a Windows Terminal session is also open. And it seems that once this warning goes away, I can't get it to come back.

@jdhitsolutions jdhitsolutions added the bug Something isn't working label Aug 1, 2020
@jdhitsolutions jdhitsolutions self-assigned this Aug 1, 2020
@jdhitsolutions
Copy link
Owner

During my last update Windows Terminal hadn't started releasing preview builds so my module wasn't taking that into account. I am updating to correct that. Thanks for bringing this up.

@jdhitsolutions
Copy link
Owner

Update to v1.8.0 and see if that works better.

@rkeithhill
Copy link
Author

I don't see the warning. Thanks.

@jdhitsolutions
Copy link
Owner

I modified the commands to detect if you are running in the preview or stable build. Assuming they don't change things again in the preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants