Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary 0.3.2 removes styles from other elements #15

Closed
michaelarnauts opened this issue Feb 23, 2021 · 3 comments
Closed

Canary 0.3.2 removes styles from other elements #15

michaelarnauts opened this issue Feb 23, 2021 · 3 comments

Comments

@michaelarnauts
Copy link

It seems since version 0.3.2, the styles of other cards are removed. I notice this with the https://github.com/custom-cards/button-card for example.

It seems obvious that this is the cause: 20f145e

@jcwillox
Copy link
Owner

Yeah, this is semi-intended, I now override the cssText option, before I was setting the actual properties, but that had issues, for example margin-right wouldn't work it needed to be marginRight and CSS variables wouldn't work e,g. --paper-color: red. So this is definitely a better method, however, it can potentially override the cssText styles from other cards, or be overridden by them too.

I'll try appending the styles to cssText, instead of overriding them which should fix this issue.

@jcwillox
Copy link
Owner

jcwillox commented Mar 4, 2021

This should be fixed in 0.3.3

@michaelarnauts
Copy link
Author

0.3.3 indeed fixed the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants