-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport type annotation syntax support for older python versions #771
Comments
A few options I see here:
I'd be open to either option 1 or 3. Thoughts @ashb? Is this something you'd be interested in contributing? |
In terms of effort I can spare l make time to do no.1, not sure I've got the spare cycles to do a full implementation. Happy to pr approach 1 |
Sounds good to me, thanks! |
@jcrist Re testing: am I right in thinking that the cibuildwheel will test against multiple versions of python, so do I need to convice the GHA pipeline to run 3.9 with and without the dep installed? |
There are ways to hack in testing without it I installed that wouldn't require another ci build - if you could just write tests for behavior with it installed I can add/fixup those afterward. |
Originally posted by @ashb in #737 (comment)
The text was updated successfully, but these errors were encountered: