Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update animation during the CoreStage::Update stage #14

Merged
merged 4 commits into from
Dec 4, 2021

Conversation

jcornaz
Copy link
Owner

@jcornaz jcornaz commented Dec 4, 2021

It looks like it's not possible to detect component removal during the CoreState::Last stage. Probably because that's when the state are reset.

So updating the animation during the post update makes harder for users to detect when an animation has ended. And it didn't make a lot of sense in the first place anyway.

This PR changes the animation update to run during the CoreStage::Update stage. So that it is easy to detect the end of an animation during the CoreStage::PostUpdate.

It includes and an example written by @johnteske that I simplified a bit.

@jcornaz jcornaz merged commit 2bcee87 into main Dec 4, 2021
@jcornaz jcornaz deleted the fix/removal-detection branch December 4, 2021 17:12
@github-actions github-actions bot mentioned this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants