Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger ECS deployments properly #190

Closed
jbrunton opened this issue Sep 7, 2024 · 2 comments
Closed

Trigger ECS deployments properly #190

jbrunton opened this issue Sep 7, 2024 · 2 comments

Comments

@jbrunton
Copy link
Owner

jbrunton commented Sep 7, 2024

Currently, the deployment with Pulumi completes even if the deployment fails, presumably since the infrastructure is running.

Deployments should fail if they don't run correctly. A deployment using https://github.com/aws-actions/amazon-ecs-deploy-task-definition might address this.
@jbrunton
Copy link
Owner Author

jbrunton commented Sep 7, 2024

Work started in #85.

@jbrunton
Copy link
Owner Author

jbrunton commented Sep 8, 2024

The ecs deployment action doesn't solve this problem, but #199 (kind of) does, albeit with a longer timeout than need be for reasons I'm not sure about.

@jbrunton jbrunton closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbrunton