Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backing up to SMS folder in gmail does not show the correct names #1060

Open
thinkscriptfan opened this issue Apr 27, 2021 · 12 comments
Open
Assignees
Labels
good first issue misattribution Confused about which phone number is the "other party"

Comments

@thinkscriptfan
Copy link

Hi , I am using smsbackup+ on pixel 3axl , latest android .
recently , I have noticed that sometimes my text to some known contacts is not backed up correctly .
instead of showing from me , it shows from +1xxxxxxx [email protected] , and instead of showing SMS with the name of the receiver , it shows SMS with +1xxxxxxx
( where +1xxxxxxx is my cell number )

I just noticed that this has been happening only in the last 2 years,

This is very serious , as the conversation threads can not be valid anymore under a certain name.

Expected behaviour from me SMS with " the name of the receiver"

Actual behaviour from +1xxxxxxx [email protected] SMS with +1xxxxxxx

Steps to reproduce the behaviour ? sometimes happens , not sure how to reproduce.

Please specify the following:

  • Android version 11
  • Phone model / brand pixel 3a xl
  • SMS Backup+ version installed version 1.5.11
  • Messaging app google message app version 7.7.050 (Neem_RC02.phone_dynamic) (SPAM protection ON)
@kurahaupo
Copy link
Collaborator

I'm pretty sure this is a continuation of a known issue. I will check for related issues shortly.

Essentially, the API used to access an individual message presents a list of addresses (phone numbers) associated with it, in no particular order.

When this app was written they were presented with the "sender" as the first address, but at some point the order became randomized, and a "type" tag was added. This is why you see your own address appearing instead of the other party's.

@kurahaupo
Copy link
Collaborator

kurahaupo commented May 29, 2021

@jberkel - I'd like your thoughts on this plan:

What needs to happen is to inspect the "type" tag on each address to find which one is the sender and then to choose based on incoming or outgoing whether the sender is the "other party" or not.

In the case of group messages it gets more complicated, as for incoming messages it would need to identify which of the recipients are "self" and which are "others". Possibly this could be learned from the 2-party messages.

If that can't be made to work reliably, then there are several options:

  1. save a separate copy for each participant
  2. include all the participants in one message, including the local user's address. They might need to be sorted & hashed into a single "address"; that will depend on conversation works in detail.

@kurahaupo
Copy link
Collaborator

Duplicate of #390

@kurahaupo kurahaupo marked this as a duplicate of #390 May 29, 2021
@kurahaupo
Copy link
Collaborator

Possibly related to #621

@kurahaupo
Copy link
Collaborator

Possibly related to #671

@kurahaupo
Copy link
Collaborator

Possibly related to #704

@kurahaupo
Copy link
Collaborator

Possibly related to #621

@kurahaupo
Copy link
Collaborator

Possibly related to #663

@kurahaupo
Copy link
Collaborator

kurahaupo commented May 29, 2021

Duplicate of #676

@kurahaupo kurahaupo marked this as a duplicate of #676 May 29, 2021
@kurahaupo kurahaupo added the misattribution Confused about which phone number is the "other party" label May 29, 2021
@kurahaupo
Copy link
Collaborator

See new bug classification misattribution

@kurahaupo
Copy link
Collaborator

See additional classification half-missing, as some of the issues with that tag may be hidden variants on the misattribution tag.

@kurahaupo
Copy link
Collaborator

@jberkel FYI need to make allowance that some MMS messages include the sender among the recipients as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue misattribution Confused about which phone number is the "other party"
Projects
None yet
Development

No branches or pull requests

3 participants