Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing reuse of vector object in View.getVector #223

Open
jkni opened this issue Feb 16, 2024 · 1 comment
Open

Consider allowing reuse of vector object in View.getVector #223

jkni opened this issue Feb 16, 2024 · 1 comment

Comments

@jkni
Copy link
Collaborator

jkni commented Feb 16, 2024

The View interface returns a unique object for every call to getVector, but the object returned by getNeighborsIterator is only guaranteed to be usable until the next call to getNeighborsIterator. If we put getVector under the same constract, we may be able to optimize the implementation for some readers and reduce object allocation.

@jbellis
Copy link
Owner

jbellis commented Apr 3, 2024

(low priority imo b/c the reranker only calls getVectorInto and not getVector)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants