Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the leading slash configurable #2

Closed
funnyfrish opened this issue Nov 28, 2019 · 2 comments
Closed

make the leading slash configurable #2

funnyfrish opened this issue Nov 28, 2019 · 2 comments

Comments

@funnyfrish
Copy link

when a base href is used than the injected js + asset file paths wont work. It always tries to
go to the main domain instead off the subfolder where the app is running

example:
domain.com/shop/app -> the injected paths with leading slash will show to domain.com/xxx.js instead of domain.com/shop/app/xxx.js.

@jbedard
Copy link
Owner

jbedard commented Nov 28, 2019

I thought this might be an issue. I think we can change / to always be ./, so it will always be relative to the html file. Is that what you're thinking?

@jbedard jbedard closed this as completed in 6c34cb6 Dec 1, 2019
@jbedard
Copy link
Owner

jbedard commented Dec 1, 2019

@funnyfrish I think I've addressed this. Previously the roots only trimmed the paths, and all paths were then assumed to be absolute. Now any paths where a root is not found are relative and navigate to the --out file (which might be in a root and get trimmed itself...).

It gets a little odd when a mix of absolute and relative paths start being used. Mixing URLs vs local paths :/

Please let me know how it goes. Might still be more to do here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants