-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting trim start #28
Comments
When it gets cold here and I'm not buried in my day job I'll add this feature if it hasn't already been. It would be nice to have. Thanks. |
So looking into it, ffmpeg android supports a start time so it should be almost trivial. I'll try to submit a PR this weekend. |
I achieved this by doing: VideoEditor.java
line 224
FfmpegController.java
line 658
line 671
line 1182
|
You can now trim a video in the latest version (0.0.6) of the plugin - https://github.com/jbavari/cordova-plugin-video-editor/tree/0.0.6#trim-a-video |
@rossmartin Thanks for all your hard work on this plugin. |
Just a note, I had issues with the duration logic (FfmpegController.java line 672)
It would output invalid commands for ffmpeg and create errors. I replaced it with:
And then javascript has to pass through the exact start time and end time strings (rather than integer durations):
|
So poking around the code it seems as though it's only possible to trim starting from the very start of the video and setting an end point via
duration
.Is there going to be any support for setting a starting trim time, or have I missed it somewhere? Thank you!
The text was updated successfully, but these errors were encountered: