feat: add --no-integrations option #1875
Conversation
|
opening as draft as not sure this is how it should look. @jmini give it a try for your executable and tell me if works for you or things missing. |
| @@ -77,7 +77,7 @@ public class Util { | |||
| Pattern.MULTILINE); | |||
|
|
|||
| public static final Pattern mainClassMethod = Pattern.compile( | |||
| "(?<=\\n|\\A)(?:public\\s)\\s*(class)\\s*([^\\n\\s]*)"); | |||
There was a problem hiding this comment.
This is an unrelated change, isn't it?
There was a problem hiding this comment.
In fact the IT tests now fail with the following error, could that be because of this?
Error: [3:134] [ERROR] no main class deduced, specified nor found in a manifest
dev.jbang.cli.ExitException: no main class deduced, specified nor found in a manifest
at dev.jbang.source.generators.JarCmdGenerator.generateCommandLineList(JarCmdGenerator.java:177)
at dev.jbang.source.generators.BaseCmdGenerator.generate(BaseCmdGenerator.java:51)
at dev.jbang.cli.Run.doCall(Run.java:93)
at dev.jbang.cli.BaseCommand.call(BaseCommand.java:145)
at dev.jbang.cli.BaseCommand.call(BaseCommand.java:21)
at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
at picocli.CommandLine.access$1500(CommandLine.java:148)
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
at dev.jbang.cli.JBang$3.handle(JBang.java:150)
at dev.jbang.cli.JBang$3.handle(JBang.java:145)
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
at picocli.CommandLine.execute(CommandLine.java:2170)
at dev.jbang.Main.main(Main.java:14)
There was a problem hiding this comment.
yeah thatwas definitely not intended.
quintesse
force-pushed
the
nointegrations
branch
2 times, most recently
from
b3abe6e to
a1c48c3
Compare
|
@maxandersen I updated the PR with the "actual" code. (The (I am starting to dislike having to copy all options to the |
quintesse
force-pushed
the
nointegrations
branch
from
a1c48c3 to
002084b
Compare
|
Hmmm weird, the error is still there... Edit: then the problem is most likely in my changes given the fact the error occurs in a Quarkus-related test. I'll look into it tomorrow (= later today). |
quintesse
force-pushed
the
nointegrations
branch
from
1d0e057 to
3e4d1bb
Compare
quintesse
force-pushed
the
nointegrations
branch
from
3e4d1bb to
502857f
Compare
|
Ok, problem fixed and I added support for a |
realized #1776 didn't require much for the first MVP.
adds a
--no-integrationsoption to disable execution of integrations.