-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 32-bit arm architecture detection missing #1773
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Before fix (copying
After fix:
(I'm glossing over the fact here that JDK21+ do not have a GA version on the platform, so while the early access ones are downloadable they |
they....? The suspense is killing me! :-) |
I know what happened there - I went to confirn something and didn't come back to finish the thought ... They ... are not likely to get updated from the ea versions listed in the |
Btw, for something completely unrelated:
After doing a gradle build of the code you can actually run the |
Thanks! I figured there was almost certainly a more "normal" workflow for this but didn't find it in the docs - I might submit a small PR for that too to help others |
That would be awesome! For completeness sake I'll then mention that the jbang script (well, "scripts", for bash-likes, CMD and Powershell) will actually use any jbang.jar that's found in the same folder (or in a |
@all-contributors please add @sxa for code |
@sxa already contributed before to code |
The initial
jbang
shell script can download it's default JDK (Unless it detects an existing JDK on the system, when it will use the java version).In all other cases, it sets the architecture to
unknown
so this PR will allow it to detect the 32-bit arm architecture properly.Noting that this will generate a merge conflict with my riscv64 PR due to the
Arch
list but it's an easy merge :-)Initially draft as I haven't test built it.