Crash if included html that extends from other html

[LuisReyes98]

Issue

The theme loader will crash if it is included a component
{% include "component.html" %}
and that component is extending from something else
{% extends "component-2.html" %}

Recreating the error

trying to run the theme multi-component-example thats has as parents component-holder and component-sitter will cause the it to crash

[naturallymitchell]

why doesn't multi-component-example inherit from base-theme?

[LuisReyes98]

Because I wanted to have the least amount of themes to recreate the error

[Arnaz87]

Does including usually works? The theme rewriter does not mind the content of the files so I don't think the issue is there. What's the error message of the crash?

[naturallymitchell]

there's no message, I believe, since torchbear panics. see jazzdotdev/jazz#214 (comment)

[naturallymitchell]

"The theme loader will crash"....?
meaning, the tera bindings.. that could go with what Keats told us in jazzdotdev/jazz#128

[Arnaz87]

It would've be nice if you had made a lighttouch branch with the themes, so one can just clone it and run it

[Arnaz87]

I can include the holder if that holder does not extends the parent

[Arnaz87]

I can also {% include "^/component-holder.html" %} so it definitely is not a template rewriter error, this is a tera bug.

[naturallymitchell]

@Arnaz87 @LuisReyes98 what exactly is the change we need to make now?

something like, "add support for X in Y"..

jazzdotdev/jazz#214 (comment)

[Arnaz87]

Error report, using tera 1.0 alpha
https://pastebin.com/0KyN7kyw

[Arnaz87]

Clone this branch of lighttouch
https://github.com/foundpatterns/lighttouch/tree/multi-component-example

[Arnaz87]

This error is most likely a Tera error, we need a pure rust-tera example of it, so that either Keats or us can fix it.

[Arnaz87]

the line the report links to
https://github.com/Keats/tera/blob/3707c9cbf4ad69e37f2995f6e909c204425f4567/src/renderer/processor.rs#L808

[Arnaz87]

Keats/tera#385

[naturallymitchell]

fixed upstream in foundpatterns/tera master