Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create_command() import #912

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

atugushev
Copy link
Member

It should be imported directly from pip._internal.commands.
See PR pypa/pip#7061 which breaks pip-tools.

Changelog-friendly one-liner: Add compatibility with pip==19.3.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

It should be imported directly from pip._internal.commands.
See PR pypa/pip#7061 which breaks pip-tools.
@atugushev atugushev added this to the 4.2.0 milestone Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #912 into master will increase coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   98.57%   99.06%   +0.48%     
==========================================
  Files          35       35              
  Lines        2247     2247              
  Branches      288      288              
==========================================
+ Hits         2215     2226      +11     
+ Misses         21       13       -8     
+ Partials       11        8       -3
Impacted Files Coverage Δ
piptools/utils.py 100% <100%> (+2.04%) ⬆️
piptools/repositories/pypi.py 95.12% <0%> (+3.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51463fc...bc2379a. Read the comment docs.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I didn't know what I'm getting myself into. Seems I'm the official reviewer now 🤣
Keep 'em coming, I don't really mind 😄

@atugushev
Copy link
Member Author

@codingjoe

Haha, I didn't know what I'm getting myself into. Seems I'm the official reviewer now 🤣
Keep 'em coming, I don't really mind 😄

Sorry for highlighting you on every compatibility fix. Thank you so much for the reviews! The clock is ticking, so I rush the fixes :)

@atugushev atugushev merged commit 25a4e99 into jazzband:master Sep 27, 2019
@codingjoe
Copy link
Member

All good, but I am gone hiking in Yosemite for a couple days. Soo it'll take some days until I'm back online.

@atugushev atugushev deleted the pip-19.3-compat-fix-import branch September 27, 2019 23:10
@atugushev
Copy link
Member Author

@codingjoe

I hope it'll be the last compatibility fix! Have a nice weekend then! 👍🥾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants