Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoCandidateFound exception #2083

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix NoCandidateFound exception #2083

merged 1 commit into from
May 1, 2024

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented May 1, 2024 •
edited
Loading

Closes #2078

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@chrysle chrysle added tests Testing and related things pip Related to pip skip-changelog Avoid listing in changelog labels May 1, 2024
webknjaz
webknjaz approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz webknjaz added this pull request to the merge queue May 1, 2024
Merged via the queue into jazzband:main with commit f83aed3 May 1, 2024
34 checks passed
@chrysle chrysle deleted the fix-ci branch May 4, 2024 13:15
@chrysle chrysle changed the title Fix CI for pip 24.1 Fix CI for pip main May 7, 2024
@chrysle chrysle changed the title Fix CI for pip main Fix NoCandidateFound exception Jul 19, 2024
@chrysle chrysle added bug Something is not working and removed skip-changelog Avoid listing in changelog labels Jul 19, 2024
@chrysle chrysle added this to the 7.4.2 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
bug Something is not working pip Related to pip tests Testing and related things
Projects
None yet
Milestone
7.4.2
Development

Successfully merging this pull request may close these issues.

[TODO][CI][pip upstream changes] Fix failing nightlies running against pip's main branch
2 participants
@chrysle @webknjaz