Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor multi-value options validation #1915

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Refactor multi-value options validation #1915

merged 2 commits into from
Jul 25, 2023

Conversation

atugushev
Copy link
Member

Move multi-value options validation logic to _validate_config().

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added refactor Refactoring code skip-changelog Avoid listing in changelog config Related to pip-tools' configuration labels Jul 16, 2023
@atugushev atugushev requested a review from chrysle July 25, 2023 19:33
chrysle
chrysle approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's merge this before #1933.

@atugushev atugushev merged commit 7386d28 into jazzband:main Jul 25, 2023
@atugushev atugushev deleted the refactor-multi-value-options-validation branch July 25, 2023 20:09
@atugushev
Copy link
Member Author

Thanks @chrysle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysle chrysle chrysle approved these changes

Assignees
No one assigned
Labels
config Related to pip-tools' configuration refactor Refactoring code skip-changelog Avoid listing in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atugushev @chrysle