Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for self-referential extras #1791

Merged
merged 13 commits into from
Apr 6, 2023
Merged

Add support for self-referential extras #1791

merged 13 commits into from
Apr 6, 2023

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Dec 28, 2022 •
edited by atugushev
Loading

Closes #1685

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

q0w
q0w commented Dec 28, 2022
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@atugushev atugushev added the bug Something is not working label Dec 28, 2022
@q0w q0w requested a review from atugushev December 29, 2022 00:14
@atugushev atugushev mentioned this pull request Apr 5, 2023
Merged
@atugushev atugushev added enhancement Improvements to functionality and removed bug Something is not working labels Apr 5, 2023
@atugushev atugushev added this to the 6.13.0 milestone Apr 5, 2023
@atugushev atugushev changed the title Resolve recursive extras Add support for self-referential extras Apr 5, 2023
atugushev
atugushev approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks 🎉

@atugushev
Copy link
Member

atugushev commented Apr 6, 2023 •
edited
Loading

I'll merge this and address coverage decrease on TYPE_CHECKING and protocol types in a following up PR (#1843).

@atugushev atugushev merged commit 2f947c6 into jazzband:main Apr 6, 2023
@atugushev atugushev mentioned this pull request Apr 6, 2023
Merged
@q0w q0w deleted the 1685 branch April 7, 2023 17:27
@burnes burnes mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
enhancement Improvements to functionality
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.

Recursive extra dependencies don't work for a private package
3 participants
@q0w @atugushev @webknjaz