-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiling input setup file in nested folders #1324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 33 33
Lines 2921 2928 +7
Branches 318 318
=======================================
+ Hits 2910 2917 +7
Misses 5 5
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peymanslh thanks! Could you add a test for this particular case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test! A few comments below:
b363772
to
db54498
Compare
Add unit test [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Fix some issues Co-authored-by: Albert Tugushev <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
db54498
to
2b1dcd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍🏼
@AndydeCleyre it's okay if we merge this before #1329? What do you think? |
Sure, I still need to add more tests, I'll rebase later and iron any wrinkles out. |
Wonderfull! Thanks, @peymanslh! |
Thanks for your review and suggestion! |
Closes #1312
Changelog-friendly one-liner: Fix compiling input
setup.py
file in nested foldersContributor checklist