Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO][CI][pip upstream changes] Fix failing nightlies running against pip's main branch #2078

Closed
webknjaz opened this issue Apr 23, 2024 · 4 comments · Fixed by #2083
Closed

[TODO][CI][pip upstream changes] Fix failing nightlies running against pip's main branch #2078

webknjaz opened this issue Apr 23, 2024 · 4 comments · Fixed by #2083
Labels
bug Something is not working ci Related to continuous integration tasks dependency Related to a dependency good first issue A good item for first time contributors to work on help wanted Request help from the community maintenance Related to maintenance processes pip Related to pip PR wanted Feature is discussed or bug is confirmed, PR needed resolver Related to dependency resolver tests Testing and related things

Comments

@webknjaz
Copy link
Member

Failure example: https://github.com/jazzband/pip-tools/actions/runs/8794562108/job/24134206791
@webknjaz webknjaz added PR wanted Feature is discussed or bug is confirmed, PR needed bug Something is not working help wanted Request help from the community tests Testing and related things maintenance Related to maintenance processes pip Related to pip dependency Related to a dependency good first issue A good item for first time contributors to work on resolver Related to dependency resolver ci Related to continuous integration tasks labels Apr 23, 2024
@hugovk
Copy link
Member

hugovk commented May 1, 2024

A new pip 24.1 release is due out any day now.

pypa/pip#12613

@hugovk
Copy link
Member

hugovk commented May 1, 2024

Last pass: https://github.com/jazzband/pip-tools/actions/runs/8716054525 Wed, 17 Apr 2024 03:54:40 GMT

First fail: https://github.com/jazzband/pip-tools/actions/runs/8732146094 Thu 18 Apr 2024 03:55:04 GMT

pypa/pip@4d09e3c (pypa/pip#12571) looks the most likely from a quick check of the commits from this window.

@webknjaz
Copy link
Member Author

webknjaz commented May 1, 2024

Thanks for taking time to look into this!

@chrysle
Copy link
Contributor

chrysle commented May 1, 2024

This seems to be the faulty line:

pip-tools/piptools/exceptions.py

Line 30 in b692edb

for candidate in sorted(self.candidates_tried):

We already had a similar case in #570.

@chrysle chrysle mentioned this issue May 1, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working ci Related to continuous integration tasks dependency Related to a dependency good first issue A good item for first time contributors to work on help wanted Request help from the community maintenance Related to maintenance processes pip Related to pip PR wanted Feature is discussed or bug is confirmed, PR needed resolver Related to dependency resolver tests Testing and related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NoCandidateFound exception chrysle/pip-tools
3 participants
@webknjaz @hugovk @chrysle