-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug where pip-compile setup.py would fail due to URL dependency #1347
Fix a bug where pip-compile setup.py would fail due to URL dependency #1347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 33 33
Lines 2883 2882 -1
Branches 309 309
==========================================
- Hits 2873 2872 -1
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nstall_req_from_line() seems good solution. approving from my side. others should check
Thanks @auvipy 🙏🏼 |
install_req_from_line, | ||
install_req_from_req_string, | ||
) | ||
from pip._internal.req.constructors import install_req_from_line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember struggling for hours to understand the difference between these two functions, and it seems that I still didn't fully get them... thanks @atugushev 👍🏽
Fixes #1346.
Changelog-friendly one-liner: Fix a bug where
pip-compile setup.py
would fail with URL deps.Contributor checklist