-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back piptools._compat.contextlib #1338
Merged
atugushev
merged 2 commits into
jazzband:master
from
atugushev:revert-back-compat-contextlib
Mar 7, 2021
Merged
Revert back piptools._compat.contextlib #1338
atugushev
merged 2 commits into
jazzband:master
from
atugushev:revert-back-compat-contextlib
Mar 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion" This reverts commit 0036708.
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
- Coverage 99.62% 99.21% -0.42%
==========================================
Files 33 33
Lines 2929 2927 -2
Branches 319 319
==========================================
- Hits 2918 2904 -14
- Misses 5 11 +6
- Partials 6 12 +6
Continue to review full report at Codecov.
|
jdufresne
approved these changes
Mar 6, 2021
@jdufresne thanks! |
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module
pip._vendor.contextlib2
has been recently removed in pypa/pip#9384, which breakspip-tools
(see failing cron jobs for the pip's master branch).This PR brings back the
piptools._compat.contextlib.nullcontext()
conext manager removed in #1283 ./cc @jdufresne