Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility to PyJWT dependency #483

Closed
BSVogler opened this issue Oct 27, 2021 · 3 comments
Closed

Compatibility to PyJWT dependency #483

BSVogler opened this issue Oct 27, 2021 · 3 comments

Comments

@BSVogler
Copy link
Contributor

In the latest changelog, some compatibility change to PyJWT is mentioned. However, this library is not mentioned in the dependencies in the setup files. It also seems that this missing dependency breaks the compatibility when updating PyJWT without updating djangorestframework-simplejwt. Using some dependency resolver like poetry this incompatibility should have been detected automatically.

@Andrew-Chen-Wang
Copy link
Member

It is listed here:

install_requires=[
'django',
'djangorestframework',
'pyjwt>=2,<3',
],

Please let me know how to resolve this for poetry.

@BSVogler
Copy link
Contributor Author

BSVogler commented Oct 27, 2021

Oh, you are right. I looked at the extra dependencies.

I thought about this issue again. I guess this case happened because a PyJWT upgrade happened without the corresponding upgrade to djangorestframework-simplejwt. After all, the fix was included in the major version upgrade and by default in poetry, the '^' operator is used which does not update on major version updates and sticks to the minor version updates. Not sure if the compatibility fix in #472 could be included in some 4.x release? I guess it is not worth the hassle because I doubt that many people have a similar setup as we had.

EDIT: looks related to this #464

@BSVogler BSVogler changed the title PyJWT dependency not listed? Compatibility to PyJWT dependency Oct 27, 2021
@Andrew-Chen-Wang
Copy link
Member

Closing due to inactivity. Also, lots of repositories rely on PyJWT and the upgrade referenced here broke a lot of stuff everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants