-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility to PyJWT dependency #483
Comments
It is listed here: djangorestframework-simplejwt/setup.py Lines 56 to 60 in 5d71586
Please let me know how to resolve this for poetry. |
Oh, you are right. I looked at the extra dependencies. I thought about this issue again. I guess this case happened because a PyJWT upgrade happened without the corresponding upgrade to djangorestframework-simplejwt. After all, the fix was included in the major version upgrade and by default in poetry, the '^' operator is used which does not update on major version updates and sticks to the minor version updates. Not sure if the compatibility fix in #472 could be included in some 4.x release? I guess it is not worth the hassle because I doubt that many people have a similar setup as we had. EDIT: looks related to this #464 |
Closing due to inactivity. Also, lots of repositories rely on PyJWT and the upgrade referenced here broke a lot of stuff everywhere. |
In the latest changelog, some compatibility change to PyJWT is mentioned. However, this library is not mentioned in the dependencies in the setup files. It also seems that this missing dependency breaks the compatibility when updating PyJWT without updating djangorestframework-simplejwt. Using some dependency resolver like poetry this incompatibility should have been detected automatically.
The text was updated successfully, but these errors were encountered: