Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update locale files #462

Closed
Andrew-Chen-Wang opened this issue Oct 1, 2021 · 4 comments · Fixed by #780
Closed

Auto update locale files #462

Andrew-Chen-Wang opened this issue Oct 1, 2021 · 4 comments · Fixed by #780

Comments

@Andrew-Chen-Wang
Copy link
Member

I think for the most part, the makemessages command for locale files doesn't create many conflicts, so having some PR made every time a new commit is pushed would be great!

@dpgraham4401
Copy link
Contributor

@Andrew-Chen-Wang would you still like to see this implemented? if so, please assign me this issue.

@Andrew-Chen-Wang
Copy link
Member Author

would appreciate thank you. The script to do this already exists in the repo; we just need a way to auto update in the CI on merge with master

@dpgraham4401
Copy link
Contributor

@Andrew-Chen-Wang After looking at what's already in the repo, I'm not clear on what a PR that would resolve this issue needs to implement. The issue seems to describe what the i18n.yaml already does. Currently that workflow is disabled but it works as expected.

From the below list of workflow descriptions, what are you looking for from a PR that closes this issue:

  1. on merge to master, run workflow and open another PR to update locales
    • Appears to be what's described in this issue and what's already in the disabled i18n.yaml workflow
  2. On PR, test if locales need to be updated, fail if they need to be updated
    • Easy and would prevent out-of-date locales being merged to master before a release.
  3. On PR, test if locales need to be updated, update the PR locale files if needed
    • A little more difficult
  4. Something else entirely? please let me know.

@Andrew-Chen-Wang
Copy link
Member Author

This was the last attempt: #540 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants