Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaggableManager doesn't base itself off of RelatedManager #803

Open
rtpg opened this issue May 11, 2022 · 0 comments
Open

TaggableManager doesn't base itself off of RelatedManager #803

rtpg opened this issue May 11, 2022 · 0 comments

Comments

@rtpg
Copy link
Contributor

rtpg commented May 11, 2022

TaggableManager is, essentially, a RelatedManager in spirit. It's fetching data off of a related table, has its prefetch cache.

Over the years we've had a couple bugs (#802 , #686 ) due to us not relying on RelatedManager and just reproducing features ad-hoc.

I haven't deeply looked into the feasibility of using RelatedManager directly. But if it's doable, it would be very good in my opinion. We might still need to do some magic to maintain some backwards compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant