Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long url path causes Http 500 #312

Closed
thenewguy opened this issue Oct 23, 2018 · 2 comments
Closed

Long url path causes Http 500 #312

thenewguy opened this issue Oct 23, 2018 · 2 comments
Assignees
Labels

Comments

@thenewguy
Copy link

I've encountered an issue with very long urls. In this particular case I am using ptrack. The middleware is raising DataError ... value too long for type character varying(190)

I would not expect silk to cause my site to stop serving pages. At the very least the error should be caught and suppressed. But it would be nice to be able to capture the silk profiling data as well.

@smaccona
Copy link
Collaborator

We can blame MySQL for this because we had to limit the model for that field to 190 characters in order to be able to create MySQL indexes on it (see #38 for a prolonged discussion).

I agree that this shouldn't cause a 500 error, and Silk should gracefully handle URLs that are longer than 190 characters. I will open a PR.

@smaccona smaccona self-assigned this Oct 23, 2018
@smaccona smaccona added the bug label Oct 23, 2018
@smaccona
Copy link
Collaborator

Closing this in favor of #179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants