Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'redis' is deprecated; please use 'redispy' #259

Closed
joovel opened this issue May 29, 2017 · 4 comments
Closed

'redis' is deprecated; please use 'redispy' #259

joovel opened this issue May 29, 2017 · 4 comments

Comments

@joovel
Copy link

joovel commented May 29, 2017

The pypi redis module stopped at 2.10.5 and new releases are not being provided. A newer module, redispy, forked 2.10.5 plus later changes, and was released on pypi. The newer module includes support for the geo commands released in Redis 3.2.

Can you change your requirements to bring in redispy instead of redis?

@edmorley
Copy link

edmorley commented Jul 26, 2017

The existing redis module (pypi) has since seen some activity:
https://github.com/andymccurdy/redis-py/commits/master

...and the only fix on the fork (pypi) not on the original is:
JamieCressey/redispy@2cc9baf

As such, I think it would be best to stick with the original. However I would re-ping them to (a) ask them to release a new version on pypi, (b) merge those outstanding PRs for that issue.

@niwinz
Copy link
Collaborator

niwinz commented Aug 29, 2017

On the end I don't have solid decision on this. So I keep this open until we'll have more better info.

@edmorley
Copy link

edmorley commented Aug 29, 2017

Since my previous message above:

  • the original project has released a new version (v2.10.6)
  • the fork hasn't had any new commits (last commit Nov 2016)
  • the only extra fix on the fork (JamieCressey/redispy@2cc9baf) now has extra proof that it's unsafe / not ready for production (see here)

As such I think it's now even more compelling to stick with the original (redis) and not switch to the fork (redispy).

@niwinz
Copy link
Collaborator

niwinz commented Aug 29, 2017

Thanks for the info. Seems like keep the original dep is the way to go.

@niwinz niwinz closed this as completed Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants