Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allowed_origin and redirect_uri wildcards #1508

Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat: allowed_origin and redirect_uri wildcards #1508

merged 1 commit into from
Oct 2, 2024

Conversation

dopry
Copy link
Contributor

@dopry dopry commented Sep 28, 2024 •
edited
Loading

Fixes #1506

Description of the Change

Implement Wildcard support in allowed origins and redirect uris

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@dopry dopry force-pushed the feat/redirect-uri-wildcards branch 9 times, most recently from 3f9215c to 713b49d Compare October 2, 2024 04:20
@dopry dopry changed the title WIP: feat: redirect uri wildcards feat: redirect uri wildcards Oct 2, 2024
@dopry dopry changed the title feat: redirect uri wildcards feat: allowed_origin and redirect_uri wildcards Oct 2, 2024
@dopry dopry force-pushed the feat/redirect-uri-wildcards branch 3 times, most recently from f4c1f4b to 2ff9cf6 Compare October 2, 2024 04:47
@dopry dopry marked this pull request as ready for review October 2, 2024 04:47
@dopry dopry requested review from n2ygk and tonial October 2, 2024 04:47
@dopry dopry force-pushed the feat/redirect-uri-wildcards branch 2 times, most recently from ceae38a to a0f8fa1 Compare October 2, 2024 04:51
tonial
tonial approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could add a test to ensure that "https://*.example.com/*" and * are not valid redirect_uri.

Apart from that, It's all good for me 👍

@dopry dopry force-pushed the feat/redirect-uri-wildcards branch from a0f8fa1 to 17cc818 Compare October 2, 2024 05:06
@dopry
Copy link
Contributor Author

dopry commented Oct 2, 2024 •
edited
Loading

@tonial

Maybe you could add a test to ensure that "https://*.example.com/*" and * are not valid redirect_uri.

* is a valid character in a uri path so https://*.example.com/* is valid, but * is not treated as a wild card.
I did add a test for just * which raises invalid scheme

n2ygk
n2ygk approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@n2ygk n2ygk merged commit 13f0ace into jazzband:master Oct 2, 2024
19 checks passed
@n2ygk n2ygk added this to the Release 3.1.0 milestone Oct 2, 2024
Tuhin-thinks pushed a commit to Tuhin-thinks/django-oauth-toolkit that referenced this pull request Oct 2, 2024
@dopry @Tuhin-thinks
feat: allowed_origins and redirect_uris wildcards (jazzband#1508)
3f9795d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonial tonial tonial approved these changes

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.1.0
Development

Successfully merging this pull request may close these issues.

feat: Wildcard support for Allowed Origins and Redirect URIs
3 participants
@dopry @n2ygk @tonial