Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Django 4.0 #182

Closed
grmoon opened this issue Apr 5, 2022 · 6 comments
Closed

Not compatible with Django 4.0 #182

grmoon opened this issue Apr 5, 2022 · 6 comments

Comments

@grmoon
Copy link

grmoon commented Apr 5, 2022

Following the installation instructions at https://django-invitations.readthedocs.io/en/latest/installation.html using Django 4.0, the migration step fails with the following error:

Stack Trace

$ python manage.py migrate
Traceback (most recent call last):
  File "manage.py", line 22, in <module>
    main()
  File "manage.py", line 18, in main
    execute_from_command_line(sys.argv)
  File "/path/to/lib/python3.8/site-packages/django/core/management/__init__.py", line 446, in execute_from_command_line
    utility.execute()
  File "/path/to/lib/python3.8/site-packages/django/core/management/__init__.py", line 420, in execute
    django.setup()
  File "/path/to/lib/python3.8/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/path/to/lib/python3.8/site-packages/django/apps/registry.py", line 116, in populate
    app_config.import_models()
  File "/path/to/lib/python3.8/site-packages/django/apps/config.py", line 304, in import_models
    self.models_module = import_module(models_module_name)
  File "/path/to/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/path/to/lib/python3.8/site-packages/invitations/models.py", line 12, in <module>
    from django.utils.translation import ugettext_lazy as _
ImportError: cannot import name 'ugettext_lazy' from 'django.utils.translation' (/path/to/lib/python3.8/site-packages/django/utils/translation/__init__.py)

This issue appears to have been fixed in 618fc4e, it just needs to be released.

@cloudcode-hungary
Copy link

Is there an ETA for the next PYPI build? We are migrating to 4.0 as of now, and failing at importing signals because of providing_args parameters. I can see that it's already fixed in the code base with 83e9000

@valberg
Copy link
Contributor

valberg commented May 31, 2022

We are waiting for #172 to be completed so we can do a "proper" release through jazzband. Hopefully it will happen sooner than later :)

@Natureshadow
Copy link

It does not seem like this will happen sooner.

This is the only dependency blocking AlekSIS' migration to Django 4.0, and forced us to push an LTS release out depending on Django 3, which will be EOL before AlekSIS 2022.6 will be EOL…

Please help us to not have to push the next release out with an unsupported Django version! If the release is blocked "only" by a CI issue, pelase do the release without the CI.

@lausek
Copy link

lausek commented Jul 26, 2022

@Natureshadow using a git dependency is not an option?

pip install git+https://github.com/jazzband/django-invitations.git@dfc65d3e0c27fe6e6d66083621348c149c47a725

@Natureshadow
Copy link

@Natureshadow using a git dependency is not an option?

Nope.

@valberg
Copy link
Contributor

valberg commented Sep 28, 2022

django-invitations 2.0.0 is compatible with django 4.0+

@valberg valberg closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants