Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to Add Access token #45

Open
abhikum1 opened this issue Jul 23, 2019 · 6 comments
Open

Not able to Add Access token #45

abhikum1 opened this issue Jul 23, 2019 · 6 comments

Comments

@abhikum1
Copy link

abhikum1 commented Jul 23, 2019

Hello Team,

I am trying to connect git with RTC using your extension. After registering the GitLab repo, while entering my access token the screen is prompting me to again enter it.

I have double cheked the setup of the dependencies and they seem to be working. Also, I have cross checked my access token and it seems to be correct. On opening the developer tools i see a request is failing (PFB) for screenshot.
image

Looking forward for you reply.

Reagards,
Abhishek

@innerjoin
Copy link
Contributor

@abhikum1 Thank you for your report. Can you confirm from looking at the requests in the developer tools that the call to /tokenStore?key= returns the correct GitLab access token?

@MartinBenninger sounds like the same issue I've experienced recently while using it. For me, from looking at the screenshot, it looks like as if the access token key and value are missing.

@abhikum1
Copy link
Author

@innerjoin yes the correct key is returned: {"token":"uoho3ewxhPgbTk4ycxCe"}

Also, while looking at the console i noticed the browser blocked Cross Domain Request.

image

However, i have allowed cross domain requests in the ccm application.
image

@innerjoin
Copy link
Contributor

@abhikum1 Did you follow the the 3.3 White List Configuration instructions from the documentation?

@MartinBenninger @SBI- Not sure whether the Whitelist configuration is sufficient. If I remember correctly, it applies only when going through the proxy endpoint, which not seems to be the case here. What needs to be configured in addition for cross origin requests here?

@SBI-
Copy link
Member

SBI- commented Jul 23, 2019

@abhikum1 Which version of gitlab are you using, and what kind of webserver / proxy-setup is being used? It looks like whatever reverse-proxy gitlab is behind is not handling any of the CORS headers.

@abhikum1
Copy link
Author

abhikum1 commented Jul 23, 2019

Gitlab version : 11.10.8
we are using docker container hosted on RHEL
https://docs.gitlab.com/omnibus/docker/
there is no proxy-setup being used as far as i know but i will confirm this with my team.

@SBI-
Copy link
Member

SBI- commented Jul 23, 2019

That doesn't preclude an error on our side, by the way. It's just something I noticed in the example screenshot. It's also possible it's just missing from the crop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants