Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASGI implementation #5

Open
jaydenwindle opened this issue Feb 4, 2020 · 1 comment
Open

Add ASGI implementation #5

jaydenwindle opened this issue Feb 4, 2020 · 1 comment

Comments

@jaydenwindle
Copy link
Owner

jaydenwindle commented Feb 4, 2020

Since Django 3.0 supports ASGI out of the box, this library doesn't necessarily need to rely on Django Channels as a dependency for newer Django projects. Instead, we could create a custom ASGI application, and use it to handle GraphQL websocket connections.

We would still need a pub/sub layer, but could use aioredis directly. This would make the code much easier to understand, since sending data to the client and responding to pub/sub events could be decoupled.

Some thoughts on implementing a custom websocket ASGI app for Django: https://jaydenwindle.com/writing/django-websockets-zero-dependencies/

@levinotik
Copy link

Nice Jayden! Will check out the post a bit later, but this makes perfect sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants