Remove error classes and use http-errors. #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http-errors
instead.Most errors were a pretty obvious conversion, but I do wonder about the errors for when the client unexpectedly disconnects. I chose the status code
499
, which is a non-standard code used by nginx forClient Closed Request
which seems like a perfect fit: https://httpstatuses.com/499.http-errors
does not have a special class for this code though, so it falls back to aBadRequestError
class name.