Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel shutdown call ignores arguments #7639

Closed
Flamefire opened this issue Aug 17, 2021 · 2 comments · Fixed by #11936
Closed

bazel shutdown call ignores arguments #7639

Flamefire opened this issue Aug 17, 2021 · 2 comments · Fixed by #11936
Assignees
Labels
bug Something isn't working contributions welcome The JAX team has not prioritized work on this. Community contributions are welcome.

Comments

@Flamefire
Copy link

The line at https://github.com/google/jax/blob/4e6aef581b90db1c1ab292a1e7f17eb97e2377ab/build/build.py#L518 should be changed to shell([bazel_path] + args.bazel_startup_options + ["shutdown"]) so that options like --output_user_root are honored.

@Flamefire Flamefire added the bug Something isn't working label Aug 17, 2021
@yashk2810
Copy link
Collaborator

Sounds good to me. Can you include an output showing if this works?

Also, if you want, you can send a PR :)

@Flamefire
Copy link
Author

Using it already with success: https://github.com/easybuilders/easybuild-easyconfigs/pull/13758/files#diff-bc1d17061c7afd8013084f11171332424020c3af87c19be5ba4bee3a909cd475

I have a read-only .bazel folder in my HOME to avoid bazel writing stuff there which is how I noticed

@hawkinsp hawkinsp added the contributions welcome The JAX team has not prioritized work on this. Community contributions are welcome. label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contributions welcome The JAX team has not prioritized work on this. Community contributions are welcome.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants